Fall back to using API key also for pushing symbol packages if nothing else was specified as parameter or config #5122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng else was specified via parameter or config #11846
ghost
added
the
|
@dotnet-policy-service agree |
kartheekp-ms
requested changes
Apr 7, 2023
…ymbolPackagePublish service to avoid leaking keys
|
@jwfx The changes look good to me. I just need some more time to review the tests. I plan to complete the review as soon as possible. Thanks for understanding. |
kartheekp-ms
approved these changes
Apr 18, 2023
jeffkl
approved these changes
Apr 18, 2023
|
Thank you guys for your quick reaction and taking the time to review this. 👍 |
@jwfx I appreciate the effort you put into contributing to the NuGet Client repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11846
Regression? Last working version:
Description
Currently it is not possible to reuse the package API key also for symbol sources on 3rd party NuGet servers.
For nuget.org this is possible because it receives a special treatment in CommandRunnerUtility.GetApiKey().
This change makes it possible for the symbol source API key to fall back to the package source API key if nothing else is specified via parameter or config.
Additional documentation should not be required, as this change brings it in line what is already documented here (Step 3 in particular).
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation