Issue2486: Hiding classic dependency options for project.json and xproj scenarios #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rohit21agrawal, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for NuGet/Home#2486
This is a pretty simple fix. It binds the visibility of the Grids which display Install & Uninstall options to an existing DataContext variable called ShowClassicOptions.
It also fixes a bug in the way ShowClassicOptions was initialized. Instead of checking for any BuildIntegratedNugetProject, the right thing to do is to check for INugetIntegratedProject, since that is the interface shared by both BuildIntegratedNugetProject & ProjectKNugetProject.
@joelverhagen @alpaix @zhili1208 @jainaashish @emgarten @rrelyea