Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowinsecureconnections option #5742

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Apr 5, 2024

Bug

Fixes: NuGet/Home#13378

Regression? Last working version:

Description

nuget add and nuget update commands do not allow for adding a new package source with an attribute allowInsecureConnections. Users would have to go to the config file manually to add this attribute.

  • This PR adds a -allowInsecureConeections option to these commands.

PR Checklist

@Nigusu-Allehu Nigusu-Allehu self-assigned this Apr 5, 2024
@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner April 5, 2024 23:34
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for focusing on a complete experience.

  • 1 question about the string.
  • Can you please file a documentation issue for this addition. This needs to capture dotnet.exe and nuget.exe and the dotnet.exe docs are in the dotnet/docs repo.

src/NuGet.Clients/NuGet.CommandLine/NuGetCommand.resx Outdated Show resolved Hide resolved
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@Nigusu-Allehu Nigusu-Allehu merged commit 96a5c3c into dev-feature-http-error Apr 16, 2024
9 of 16 checks passed
@Nigusu-Allehu Nigusu-Allehu deleted the dev-nyenework-allowinsecureconnections-option branch April 16, 2024 17:31
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 22, 2024
Nigusu-Allehu added a commit that referenced this pull request May 23, 2024
Nigusu-Allehu added a commit that referenced this pull request Jun 17, 2024
aortiz-msft pushed a commit that referenced this pull request Jun 18, 2024
* Deprecate http usage: `nuget search` promote warning to error for http sources (#5693)

* Deprecate http usage: `nuget list` promote warning to error for http sources (#5698)

* Deprecate http usage: `nuget push` promote warning to error for http sources (#5705)

* Deprecate http usage: `delete` operations, promote warning to error for http sources (#5703)

* Add `allowinsecureconnections` option (#5742)

* remove integration test for now (#5758)

* Deprecate http: Promote from warning to error in VS Options NuGet Package Manager (#5732)

* Deprecate http usage: `source` commands, promote warning to error for http sources (#5702)

* Deprecate http usage: `restore` scenarios promote warning to error for http sources (#5731)

* use `--allow-insecure-connections` for dotnet nuget add command (#5853)

* tests

* clean up

* clean up

* white space

* tests

* comment
Nigusu-Allehu added a commit that referenced this pull request Jul 2, 2024
Nigusu-Allehu added a commit that referenced this pull request Jul 2, 2024
Nigusu-Allehu added a commit that referenced this pull request Jul 2, 2024
Nigusu-Allehu added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants