-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add allowinsecureconnections
option
#5742
Merged
Nigusu-Allehu
merged 4 commits into
dev-feature-http-error
from
dev-nyenework-allowinsecureconnections-option
Apr 16, 2024
Merged
Add allowinsecureconnections
option
#5742
Nigusu-Allehu
merged 4 commits into
dev-feature-http-error
from
dev-nyenework-allowinsecureconnections-option
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for focusing on a complete experience.
- 1 question about the string.
- Can you please file a documentation issue for this addition. This needs to capture dotnet.exe and nuget.exe and the dotnet.exe docs are in the dotnet/docs repo.
jeffkl
reviewed
Apr 9, 2024
JonDouglas
reviewed
Apr 15, 2024
nkolev92
reviewed
Apr 15, 2024
nkolev92
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
8 tasks
Nigusu-Allehu
added a commit
that referenced
this pull request
May 22, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
May 22, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
May 22, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
May 22, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
May 23, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jun 17, 2024
aortiz-msft
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Deprecate http usage: `nuget search` promote warning to error for http sources (#5693) * Deprecate http usage: `nuget list` promote warning to error for http sources (#5698) * Deprecate http usage: `nuget push` promote warning to error for http sources (#5705) * Deprecate http usage: `delete` operations, promote warning to error for http sources (#5703) * Add `allowinsecureconnections` option (#5742) * remove integration test for now (#5758) * Deprecate http: Promote from warning to error in VS Options NuGet Package Manager (#5732) * Deprecate http usage: `source` commands, promote warning to error for http sources (#5702) * Deprecate http usage: `restore` scenarios promote warning to error for http sources (#5731) * use `--allow-insecure-connections` for dotnet nuget add command (#5853) * tests * clean up * clean up * white space * tests * comment
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 2, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 2, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 2, 2024
Nigusu-Allehu
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13378
Regression? Last working version:
Description
nuget add
andnuget update
commands do not allow for adding a new package source with an attributeallowInsecureConnections
. Users would have to go to the config file manually to add this attribute.-allowInsecureConeections
option to these commands.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation
https://github.com/Add documentation forallowInsecureConnections
option Home#13498 , https://github.com/Add documentation forallowInsecureConnections
option dotnet/docs#40488