Fix PackageSourceProvider.UpdatePackageSource doesn't respect a value from AllowInsecureConnection field
#5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
Community
There was a problem hiding this comment.
Good catch! We're adding -allowInsecureConnections option to the update and add commands. With it we have also addressed this problem: #5742. However, it is not ready for release yet as it is just a sub part of another project.
|
Nice, I didn't check that PR for an already implemented fix, thanks for noticing! So what about this one? Maybe let's proceed with it to address the problem quicker? |
nkolev92
approved these changes
Apr 26, 2024
src/NuGet.Core/NuGet.Configuration/PackageSource/PackageSourceProvider.cs
Show resolved
Hide resolved
Nigusu-Allehu
approved these changes
Apr 30, 2024
8 tasks
seclerp
added a commit
to JetBrains/NuGet.Client
that referenced
this pull request
May 6, 2024
…ue from `AllowInsecureConnection` field (NuGet#5767)
Rizzen
pushed a commit
to JetBrains/NuGet.Client
that referenced
this pull request
May 6, 2024
…ue from `AllowInsecureConnection` field (NuGet#5767)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13418
Regression? Last working version:
Description
Hi, so this is quite a simple fix. The missing if check prevented update logic if only AllowInsecureConnections was changed.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation