Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for native-txm folder #620

Closed
wants to merge 1 commit into from
Closed

Conversation

emgarten
Copy link
Member

This change adds support for /runtimes/{rid}/native-txm/{tfm}/ Nupkgs can use this to specify a native dependency that pivots on both framework and rid.

NuGet/Home#2782

//cc @alpaix @zhili1208 @rohit21agrawal @rrelyea @ericstj @davidfowl

@ericstj
Copy link
Contributor

ericstj commented May 25, 2016

Why did you have to use native-txm instead of just native and have it behave similar to MSBuildFiles? (eg: prefer TFM folder if it exists, but fallback to no-TFM)

@emgarten
Copy link
Member Author

@ericstj that behavior has been a problem for the lib folder since all framework names must be hardcoded/known for it to work consistently.

Im open to any suggestions on the path, I'd just really like to avoid tfm/sub folder conflicts completely.

@ericstj
Copy link
Contributor

ericstj commented May 26, 2016

Are you worried about packages that exist today that had a net45 folder which didn't expect for it to be a TFM filter? Are you worried about packages that have a 'foo' folder today and we create a 'foo' TFM sometime in the future?

@rohit21agrawal
Copy link
Contributor

:shipit:

@davidfowl
Copy link
Member

native-txm looks so odd.

@rrelyea
Copy link
Contributor

rrelyea commented Jun 11, 2016

Yes, we renamed it to "assets", then "nativeassets". Discussion is in the PR, I believe.

@emgarten emgarten closed this Jun 13, 2016
@emgarten emgarten deleted the emgarten/nativeLib branch June 15, 2016 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants