Avoid adding nuget actions for dependencies if dependency behavior is ignore #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set to ignore. Fix NuGet/Home#1298
| @@ -1111,14 +1111,17 @@ private void InitializePackagesFolderInfo(string packagesFolderPath, bool exclud | |||
|
|
|||
| var installedPackagesInDependencyOrder = await GetInstalledPackagesInDependencyOrder(nuGetProject, token); | |||
|
|
|||
| var isDependencyBehaviorIgnore = resolutionContext.DependencyBehavior == DependencyBehavior.Ignore; | |||
There was a problem hiding this comment.
Why map the DependencyBehavior enum to a bool? Couldn't you pass it all the way down and make this == check at the last moment?
There was a problem hiding this comment.
Actually, I take that back. Passing down a bool is better in this case since the bool is used in multiple places.
|
Address comment then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating packages, it currently gets all the dependencies for target packages to generate nuget actions even though dependency behavior is set to ignore. This change will avoid it so that update won't fail or throw some random error for missing dependencies when passing IgnoreDependencies flag.
Fix NuGet/Home#1298
@rrelyea @joelverhagen @emgarten @alpaix