NuGetGallery.Core update with new storage SDK #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligning not found exception catching with the original code.
drewgillies
previously approved these changes
Jun 25, 2024
|
@agr |
|
@erdembayar it can be fixed separately, it's not really related to NuGetGallery.Core update. |
|
@agr |
drewgillies
approved these changes
Jun 28, 2024
erdembayar
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on https://github.com/NuGet/Engineering/issues/5335.
NuGet.Jobs counterpart of NuGet/NuGetGallery#10018
NuGetGallery.Core update to new storage SDK brought some API changes. Mostly replacing previously exposed underlying SDK types with abstractions provided by NuGetGallery.Core.
Tested the following jobs after update (those use NuGetGallery.Core pretty extensively):
Besides that, verified, that some other jobs that rely on feature flag functionality (which again uses NuGetGallery.Core abstractions), still have that functionality working.