Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Save" on the confirmation prompt when navigating away from the /Edit page doesn't actually save changes. #1469

Closed
claycompton opened this issue Aug 16, 2013 · 2 comments
Assignees

Comments

@claycompton
Copy link

  1. Log in and go to the package page for a package you own.
  2. Click "Edit Package" and change one of the available fields.
  3. Without clicking the "Save" button on the page, click the "Home" link in the navigation bar.
  4. You'll be prompted with a confirmation box with three options, Save, Don\t Save, and Cancel. Click "Save".
  5. Go back to the package page again.

RESULT: Your changes don't show up as pending edits.
EXPECTED: I'd hope for this to have the same effect as clicking the actual "Save" button on the page.

@TimLovellSmith
Copy link
Member

I can't repro this bug per se:
I suspect the issue may be that either
a) page caching shows you the package page as you saw it previously, with no pending edits, because you got there using the back button
b) server-side validation failed the request, and the script doesn't detect that case and cancel navigation

I think we can fix a). I'm less sure if it's a good idea.
I'll also try to fix b).

@johnataylor
Copy link
Member

Looks like this is in staging. We need to make sure we have tested this.

TimLovellSmith pushed a commit that referenced this issue Aug 30, 2013
…ome other issues such as flickering visible message about 'you are about to navigate away' and issue where dialog is still visible after being 'dismissed' when you use back button to return to the edit page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants