Fix 1469 save button doesnt always appear to work #1488
Conversation
Fix GetUpdates case-sensitivity issue
|
Rebasing on latest qa. |
| // --------------------------- | ||
| // The form could not be saved: The Description (a longer description) field is required. | ||
| // --------------------------- | ||
| var fixedStr = error.ErrorMessage; |
There was a problem hiding this comment.
This feels really hacky, but I guess it'll do. There are unhandled edge cases like there not being a ) in the string, but I can't see that happening. I probably would have done a regex replacement.
|
Here's an alternate proposal to fixing this problem... When the user clicks a link to navigate to a different version, instead of doing the whole AJAX dance, we could just submit the form and include a field in the form for the desired next page. Then the existing POST action for the form would kick in and server-side validation would happen just like the user hit the Save button. If there are errors, the page would be rendered with them. If there aren't any errors, then instead of having the action redirect the user back to the package details page, it would redirect to the desired next page. |
…ome other issues such as flickering visible message about 'you are about to navigate away' and issue where dialog is still visible after being 'dismissed' when you use back button to return to the edit page.
|
Closing this and submitting new fix against staging. |
Fixing #1469 by capturing errors from server side validation and presenting them to the user.