Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Service can double-dequeue! #2151

Closed
analogrelay opened this issue May 15, 2014 · 0 comments · Fixed by NuGet/NuGet.Services.Work#29
Closed

Work Service can double-dequeue! #2151

analogrelay opened this issue May 15, 2014 · 0 comments · Fixed by NuGet/NuGet.Services.Work#29
Assignees

Comments

@analogrelay
Copy link
Contributor

This is a Bad Thing(TM). We have a race in the DequeueInvocation SPROC where it can end up modifying the same invocation twice. We were being too aggressive about optimizing locks and ended up under-locking. Since this is such a fast and relatively rare operation on a low-traffic DB, let's just lock the whole darn thing.

Test Notes: This is basically a heisenbug, meaning it's really hard to repro, but it always seems to show up with the copy database job, so as long as the backups are being created and not flooding the server with "copytemp_" databases, we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant