Search by Title, Id, Author, Description fields - enhanced UI and ready for merge #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
November 29, 2012 15:43
The first unit test is FAILing to find the word 'awesome' in the package description.
LuceneSearchService to use in-memory indexes during unit test runs.
…lly running website.
…ization. Motive - trying to get all my new tests to pass.
…merge is screwing me.
But search such as 'id:NuGet assembly' results seem pretty random still.
…Ids work better and for Id phrase searches to work.
…sing stop words in the Query.
…arches with Tags: and Author: search. Also refine the way search strings are presented so that quote marks used in searches are less confusing. And revert some temporary debugging changes.
|
ping for review |
| { | ||
| public class LuceneSearchServiceFacts | ||
| { | ||
| private Directory _d; |
There was a problem hiding this comment.
Can we refactor these tests to avoid using an instance variable? xUnit does create a separate instance per-test, but I'd rather not depend on that. Maybe have the code that sets this use a Tuple or out-param to set it? I don't really like those either but they're clearer than a magic instance variable :).
added 3 commits
December 10, 2012 16:45
…and offline by Pranav. Search no longer hits SQL!
|
Thanks for all the feedback so far, it's helped! Who's up for round 2? :) |
This was referenced Jan 3, 2013
joelverhagen
pushed a commit
that referenced
this pull request
Jul 30, 2024
Mirrors NuGet/Samples#34, discovered by @jstoker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #659 and #668. Enhances Tag and Author links to do searches on relevant fields only.