Status Page. Currently, checks the availability of SQL Azure and Storage #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage 1) Checking Storage Availability by checking if nuget.exe exists in storage 2) Checking SQL Azure Availability by selecting 1 key from Packages Table
| private const string Unavailable = "Unavailable"; | ||
| private const string StatusMessageFormat = "NuGet Gallery service is {0}. SQL Azure is {1}. Storage is {2}"; | ||
|
|
||
| private const string TestSqlQuery = "SELECT TOP(1) [Key] FROM Packages"; |
There was a problem hiding this comment.
I recommend hitting the GallerySettings table instead of Packages. And use a WITH (NOLOCK) hint too.
There was a problem hiding this comment.
Based on your comment, I have updated the table to 'Users' WITH (NOLOCK). Since it is TOP(1) with (NO LOCK) on Key, it should be really quick. And, I prefer Users over other tables because, it covers incomplete imports too. Incomplete imports generally have an empty 'Users' Table. I am guessing import loads the tables alphabetically
This means 2 things. If we are not okay with that, I will change it to GallerySettings instead of Users
- Primary service's health is still measured correctly with this query. This is good
- Failover service's health is better measured with this query. But, 'Primary Ops' will likely receive a phone call even for an incomplete import to Failover as against a Failover that is truly fully down. I would like to think that an incomplete import is just as bad as a unavailable DB
deepakaravindr
added a commit
that referenced
this pull request
May 14, 2014
Status Page. Currently, checks the availability of SQL Azure and Storage
|
Fixes #2155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status Page. Currently, checks the availability of SQL Azure and Storage