Fix password autocomplete #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blowdart , looks good? |
|
What does the experience in the browser looks like when this attribute is not applied (i.e. current state in PROD)? |
|
Chrome for example lets you choose which password to apply in the field |
chenriksson
approved these changes
Jul 24, 2017
joelverhagen
approved these changes
Jul 24, 2017
|
Created a bug Joel: https://github.com/NuGet/Engineering/issues/623 |
|
@skofman1 thanks!! |
| @@ -319,12 +319,12 @@ | |||
| @Html.ValidationSummaryFor("ChangePassword") | |||
| <div class="form-field"> | |||
| @Html.LabelFor(m => m.ChangePassword.OldPassword) | |||
| @Html.PasswordFor(m => m.ChangePassword.OldPassword) | |||
| @Html.PasswordFor(m => m.ChangePassword.OldPassword, new { autocomplete = "off" }) | |||
There was a problem hiding this comment.
You sure this works? AFAIK, browsers are disregarding autocomplete=off on password fields (IE11, FF, Chrome).
https://msdn.microsoft.com/library/ms533486
https://bugzilla.mozilla.org/show_bug.cgi?id=956906#c100
https://bugs.chromium.org/p/chromium/issues/detail?id=352347 https://bugs.chromium.org/p/chromium/issues/detail?id=587466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this: https://github.com/NuGet/Engineering/issues/622