Fix minor bugs in Deprecation UI found in bug bash #6994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
anangaur,
cristinamanum,
skofman1 and
zhhyu
shishirx34
reviewed
Mar 13, 2019
| } | ||
| else | ||
| { | ||
| <span>Deprecating a package will warn all consumers of the package who use it in their projects.</span> |
There was a problem hiding this comment.
should this be attributed with AlertInfo
There was a problem hiding this comment.
No, it's meant to appear as plain text at the top of the section as a description. We could make it an AlertInfo but I'm not sure if it's necessary or if it would look better.
joelverhagen
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quick bugs found in https://github.com/nuget/engineering/issues/2168
"skip to content" does not tab to the deprecation warning on the package details page (non-focusable elements with
tabIndexset should be considered:focusableand:tabbable)Fixed page when package is locked or feature flag is disabled
site admin:
owner:
deprecation warning on package details page should show pointer cursor
custom message in deprecation warning on package details page should have better text
alternate package text in deprecation warning on package details page should be shorter