Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor bugs in Deprecation UI found in bug bash #6994

Merged
merged 2 commits into from Mar 13, 2019

Conversation

@scottbommarito
Copy link
Member

scottbommarito commented Mar 13, 2019

Some quick bugs found in NuGet/Engineering#2168

  • multi-select dropdown should not be larger than content

image

  • "skip to content" does not tab to the deprecation warning on the package details page (non-focusable elements with tabIndex set should be considered :focusable and :tabbable)

  • Fixed page when package is locked or feature flag is disabled

site admin:

image

owner:

image

  • deprecation warning on package details page should show pointer cursor

  • custom message in deprecation warning on package details page should have better text

  • alternate package text in deprecation warning on package details page should be shorter

image

}
else
{
<span>Deprecating a package will warn all consumers of the package who use it in their projects.</span>

This comment has been minimized.

@shishirx34

shishirx34 Mar 13, 2019

Contributor

should this be attributed with AlertInfo

This comment has been minimized.

@scottbommarito

scottbommarito Mar 13, 2019

Author Member

No, it's meant to appear as plain text at the top of the section as a description. We could make it an AlertInfo but I'm not sure if it's necessary or if it would look better.

image

@shishirx34
Copy link
Contributor

shishirx34 left a comment

one comment. :shipit:

@scottbommarito scottbommarito changed the base branch from master to dev Mar 13, 2019

@scottbommarito scottbommarito merged commit 5972daf into dev Mar 13, 2019

2 checks passed

NuGetGallery - CI #53273 succeeded
Details
license/cla All CLA requirements met.
Details

@scottbommarito scottbommarito deleted the sb-quickbugbash branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.