Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk revalidate buttons to Validation admin panel #8738

Merged
merged 4 commits into from
Aug 11, 2021
Merged

Conversation

joelverhagen
Copy link
Member

Fix #8702.

This PR makes three changes to the Validation admin panel

  1. Polish: Redirect back to admin panel when clicking an individual revalidate (feedback in retrospective from @loic-sharma)
  2. Bug fix: Fix the individual revalidate link. Previously, only the first form on the page worked due to duplicate IDs 😨
  3. Feature: Adds two links to the Validation admin panel
    • Revalidate pending packages
    • Revalidate pending symbol packages

Each link queries for all entities of the respective type that are in the Validating state then enqueues a validation for each entity.

Each link has a confirmation dialog to avoid accidental clicks.

revall

@joelverhagen joelverhagen requested a review from a team as a code owner August 6, 2021 00:15
@@ -87,14 +117,15 @@
{
{ "id", package.Id },
{ "version", package.NormalizedVersion },
{ "returnUrl", Url.Current() },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@joelverhagen joelverhagen merged commit 3759c27 into dev Aug 11, 2021
@joelverhagen joelverhagen deleted the jver-revall branch August 11, 2021 17:38
@loic-sharma loic-sharma mentioned this pull request Aug 18, 2021
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants