Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y bug] Add visual representation for required field on forgot password page. #9049

Merged
merged 2 commits into from
Mar 14, 2022
Merged

[A11y bug] Add visual representation for required field on forgot password page. #9049

merged 2 commits into from
Mar 14, 2022

Conversation

dannyjdev
Copy link
Contributor

Changes

  • Every label element with class required inside another element with form-group class will have the red * as a representation of a required field.

Example:

<div class="form-group">
    <label class="required">Email: </label>
</div>

Screenshots

Before

before - email required

After

email required

email required 2

Current API Key page for required input

apikey required

Addresses https://github.com/nuget/engineering/issues/4309

@dannyjdev dannyjdev requested a review from a team as a code owner March 11, 2022 23:49
@dannyjdev dannyjdev merged commit 8e722a3 into dev Mar 14, 2022
@dannyjdev dannyjdev deleted the dev-dj-a11y-emailforgot branch March 14, 2022 18:05
@dannyjdev dannyjdev mentioned this pull request Mar 22, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advay26 advay26 advay26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyjdev @advay26