-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully Qualify Install-Package command on website #9203
Conversation
@@ -133,6 +135,15 @@ | |||
Id = Model.IsCakeExtension() ? "cake-extension" : "cake", | |||
InstallPackageCommands = new [] { Model.GetCakeInstallPackageCommand() }, | |||
}, | |||
|
|||
new PackageManagerViewModel("PowerShell") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a hypothesis that most NuGet packages does not make good PowerShell packages. My understanding is that the structure and contents of the packages are quite different. NuGet packages are essentially DLLs compiled against or used for build/deploy of .NET projects. PowerShell packages are .ps1 or module files for a PowerShell session. It might give folks the wrong impression if we mention PackageManagement\Install-Package
. Wouldn't this command be more appropriate on PowerShell Gallery (https://www.powershellgallery.com/).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PowerShell community does indeed use nugets outside of Visual Studio. I use it enough to get frustrated with the fact that the command on the website doesn't work.
Installing arbitrary assemblies from http://nuget.org is something we want to support in PSGet v3.1 so after 3.0 is complete
Patrick Meinecke of the PowerShell team said
For now, I usually tell folks to build a binary module instead.
You can also build a csproj, add your dependencies, do dotnet publish and copy the dependencies out. It's not a great experience atm.
Another PS community member talks about how he handles nuget packages
A csproj file with PackageReference and a build.ps1 script to import the dependencies in the right location is still how I'm doing it. Not the best, but it works
So there is interest, and we do use it but it's not enjoyable (though as Steve mentioned, enhancements are coming soon). Ultimately, if there is a PowerShell tab, people like me will click it and it reenforces that the first tab isn't for us.
We use Install-Module
on the PowerShell Gallery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this additional context! I think we might be able to make quicker progress if we split this into two separate issues:
- Make
NuGet\
prefix on the command with a note on why. This seems like obvious goodness to me since it at least helps people know that there's twoInstall-Package
commands floating around in the world. - Help PowerShell users know about how to use NuGet packages or, with that upcoming feature, use normal dependency NuGet packages (arbitrary DLLs) from PowerShell.
I'm concerned about item 2 because the vast majority of packages on NuGet.org don't work well with PowerShell's (or PSGet's) current feature set.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. When the feature is released, do you think we could add the PowerShell tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. When the feature is released, do you think we could add the PowerShell tab?
I think it would be quite reasonable to add! We need to consider the full scenario, get some input from the PowerShell team, etc, but I see know reason why this isn't in a similar category as the Cake or Paket categories. Essentially, it's not specifically NuGet client tooling involved but it is a scenario that has NuGet packages (from NuGet.org) in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic news! I'll keep it on their radar /cc @SteveL-MSFT
@potatoqualitee, could you rebase this on |
Co-authored-by: Joel Verhagen <joel.verhagen@gmail.com>
3447a14
to
5a72e9b
Compare
Summary of the changes (in less than 80 characters):
Addresses #9201