Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package project #228

Merged
merged 11 commits into from
Sep 23, 2017
Merged

Package project #228

merged 11 commits into from
Sep 23, 2017

Conversation

clairernovotny
Copy link
Member

Updates to VS 2017 and simplifies the projects. Also uses the new packaging project in VS 2017 15.4 for the Windows Store

@304NotModified
Copy link
Member

👍

AppVeyor is still using msbuild 14 I see. I think we need at least image: Visual Studio 2017

@clairernovotny
Copy link
Member Author

Will add that

@304NotModified
Copy link
Member

Please double check the artifacts in AppVeyor. (master build: https://ci.appveyor.com/project/NuGetPackageExplorer/nugetpackageexplorer/build/3.23.0.313/artifacts)

thx!

@304NotModified
Copy link
Member

304NotModified commented Sep 23, 2017 •
edited

did the build moved from 30sec -> 2 minutes?

(see https://ci.appveyor.com/project/NuGetPackageExplorer/nugetpackageexplorer/history)

@clairernovotny
Copy link
Member Author

The VS preview images are on slower hosts

@304NotModified
Copy link
Member

The VS preview images are on slower hosts

On AppVeyor? Really? That's :(

@clairernovotny
Copy link
Member Author

Artifacts should be good now.

@304NotModified
Copy link
Member

304NotModified commented Sep 23, 2017 •
edited

is the changed (version) names of the nupkg on purpose?

@clairernovotny
Copy link
Member Author

The versions are automated now. They only have the git hash on non-release branches like PRs. The definition of release branch is in the version.json.

@304NotModified
Copy link
Member

👍

@clairernovotny
Copy link
Member Author

Good to merge?

@304NotModified 304NotModified merged commit 7904e7c into NuGetPackageExplorer:master Sep 23, 2017
@304NotModified
Copy link
Member

Yes :)

@clairernovotny clairernovotny deleted the package-project branch September 23, 2017 23:17
@304NotModified 304NotModified mentioned this pull request Sep 26, 2017
Merged
20 tasks
@ridomin ridomin mentioned this pull request Oct 21, 2017
Closed
@304NotModified 304NotModified added this to the 3.24 milestone Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.24
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clairernovotny @304NotModified