Support sibling snupkg file #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
force-pushed
the
load-sibling-snupkg-file
branch
from
c3814dd
to
8036cb9
Compare
drewnoakes
force-pushed
the
load-sibling-snupkg-file
branch
from
8036cb9
to
34e5460
Compare
|
I’ll test and merge tomorrow, thanks! |
clairernovotny
requested changes
Apr 4, 2020
| requireExternal = true; | ||
| if (response.IsSuccessStatusCode) // we'll get a 404 if none | ||
| { | ||
| requireExternal = true; |
There was a problem hiding this comment.
We need to set requireExternal to true for the local snupkg case as well. This is because it'll ultimately require a symbol server to work.
|
Oh, one other thought -- as long as we're checking for |
drewnoakes
force-pushed
the
load-sibling-snupkg-file
branch
2 times, most recently
from
f9ea300
to
b500bea
Compare
| { | ||
| ReadSnupkgFile(snupkgFilePath); | ||
| } | ||
| if (File.Exists(symbolsFilePath)) |
When opening a nupkg file from disk, if its symbols are in a .snupkg or .symbols.snupkg file next to it, it would be flagged as having no symbols. This commit tests for such a file, using it if possible, before returning to the prior behaviour of checking nuget.org for packages identified as coming from there.
drewnoakes
force-pushed
the
load-sibling-snupkg-file
branch
from
b500bea
to
263c62c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #925.
When opening a
nupkgfile from disk, if its symbols are in asnupkgfile next to it, it would be flagged as having no symbols. This commit tests for such a file, using it if possible, before returning to the prior behaviour of checking nuget.org for packages identified as coming from there.