Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Possibility to name the branch NuKeeper makes for adding the updates #813

Closed
1 of 7 tasks
StephanTuinder opened this issue May 31, 2019 · 8 comments
Closed
1 of 7 tasks
Labels

Comments

@StephanTuinder
Copy link
Contributor

🚀 Feature Requests

possibility to name the branch NuKeeper makes for adding the updates

Contextualize the feature

By naming the branch NuKeeper creates, it is possible to make several runs of NuKeeper
contribute to the same pullrequest.
Also it makes it possible to have a coherent naming of branches that belong to each other:
Nuget code updated for "AwsomeFeature". For all NuKeeper updates of this nuget the branch/pullrequest can also be named "AwsomeFeature"

Describe the feature

If the branchname is given, NuKeeper should check if this branch exists and skip creating the branch, if not, it should create the branch with the given name.
If the pullrequest exists on given branch NuKeeper should skip creating the pullrequest.

Platforms affected (mark all that apply)

  • 🛠️ NuKeeper CLI
  • ✨ GitHub
  • 🤖 AzureDevops
  • 🏁 Bitbucket
  • 🌎 Gitlab
  • 📺 Gitea
  • 🐳 Docker
@MarcBruins
Copy link
Member

MarcBruins commented May 31, 2019

This is already possible with the branchNamePrefix parameter? https://nukeeper.com/basics/configuration/

@MaxMommersteeg
Copy link
Contributor

I don't think that is the feature that @StephanTuinder wants. Say you have a working branch named feature/foo he wants to explicitly target the branch for NuKeeper updates. He doesn't only want to add a prefix to generated branch name, but also to just specify the branch name that gets created entirely.

@StephanTuinder
Copy link
Contributor Author

@MaxMommersteeg Correct

@MaxMommersteeg
Copy link
Contributor

Besides from more control over branch naming, does this introduce any other functionality that isn't available right now with target branch option?

@Chama-StephanTuinder
Copy link
Contributor

Chama-StephanTuinder commented Jun 2, 2019

targetbranch option selects the branch Nukeeper will run against. I propose a feature with which you can determine what the branch nukeeper creates and updates will be named.

@batkaevruslan
Copy link

It would be great as we have branch name checks for Pull Requests.

@StephanTuinder
Copy link
Contributor Author

PR is waiting to be approved for this: #841

AnthonySteele pushed a commit that referenced this issue May 5, 2020
…(Feature #813) (#841)

* All is there except for BitBucketLocal, working on that.

* test fix

* BitBucketLocal update.

* Textual change and site update

* Fix Conflicts

* Fixes after merge and test

* test fix after merge

* typo

* Removed coda that potentially could destroy work

* Some fixes SonarQube pointed out and fixes for GitCmdDriver(test)

* usings fix

* added NukeeperLogger to last test

Co-authored-by: Stephan Tuinder <stuinder@sib.inlichtingenbureau.nl>
@stale
Copy link

stale bot commented May 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 10, 2020
@stale stale bot closed this as completed May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants