Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

[Azure Devops] Auto complete support #1005

Merged

Conversation

Berreek
Copy link
Contributor

@Berreek Berreek commented Jul 19, 2020

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature.

⤵️ What is the current behavior?

Cannot mark PR as autocompleted.

🆕 What is the new behavior (if this is a feature change)?

Can mark PR as autocompleted by using new configuration parameter (setautocomplete) in repo command.

💥 Does this PR introduce a breaking change?

No, parameter is optional and set to false on default.

🐛 Recommendations for testing

N/A

📝 Links to relevant issues/docs

#938

🤔 Checklist before submitting

  • All projects build
  • Relevant documentation was updated

Bartosz Behring added 7 commits May 4, 2020 10:11
# Conflicts:
#	NuKeeper.AzureDevOps/AzureDevOpsRestClient.cs
#	NuKeeper.AzureDevOps/AzureDevOpsSettingsReader.cs
#	NuKeeper.AzureDevOps/BaseSettingsReader.cs
#	NuKeeper.AzureDevOps/TfsSettingsReader.cs
#	NuKeeper.AzureDevOps/VSTSSettingsReader.cs
#	NuKeeper.BitBucket/BitbucketSettingsReader.cs
#	NuKeeper.Gitea/GiteaSettingsReader.cs
#	NuKeeper/Commands/RepositoryCommand.cs
#	NuKeeper/Engine/Packages/PackageUpdater.cs
#	Nukeeper.BitBucketLocal/BitBucketLocalSettingsReader.cs
@jozefchmelar
Copy link

Thank you for your code @Berreek ! I used it in my fork and it works perfectly.

@skolima skolima added the azure label Aug 29, 2020
@Berreek
Copy link
Contributor Author

Berreek commented Sep 28, 2020

@skolima Any update for it?

@skolima skolima mentioned this pull request Sep 30, 2020
7 tasks
@skolima
Copy link
Collaborator

skolima commented Sep 30, 2020

Could you update from master so that this branch builds, please? I'm also not sold on the naming - it's specific to Azure, while adding a general option. Azure calls this "set auto-complete" flag https://docs.microsoft.com/en-us/azure/devops/repos/git/pull-requests?view=azure-devops while GitHub (and Dependabot) call this auto-merging ( dependabot/feedback#954 ) and that's naming I'm more familiar with.

What would you say about naming the option setautomergeflag? (docs updated accordingly once we settle on a name).

@AnthonySteele could you perhaps comment?

@Berreek
Copy link
Contributor Author

Berreek commented Oct 1, 2020

I updated the branch.

Regarding the name - I called it auto-complete beacuse I looked only on Azure to be honest. I agree with you that auto-merge will get better understanding since complete is Azure specific as you said.

Let me know if we stick with it.

@Berreek
Copy link
Contributor Author

Berreek commented Nov 2, 2020

@skolima I renamed the option from setautocomplete to setautomerge - is there something else that need to be done in order to merge that PR?

@ykysel
Copy link

ykysel commented Nov 18, 2020

@Berreek @skolima could we get this merged? It will be very helpful

@skolima
Copy link
Collaborator

skolima commented Nov 18, 2020

Truth be told, I don't think any of the original developers uses NuKeeper any more. But I'll try to find time to release this.

@skolima skolima merged commit cdf81c6 into NuKeeperDotNet:master Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants