This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Support --targetBranch for Azure Devops Server/TFS for remote repositories
#1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to verify that when a custom value is provided to the `--targetBranch` option, the `TfsSettingsReader` properly populates the `RemoteInfo.BranchName` property in case of a remote URI for the repository.
Currently the `repository` command does not make use of the custom value provided through the `--targetBranch` option when the URI points to a remote repository, not a local one. This was the case because the `TfsSettingsReader` did not make use of the value in case of a remote URI. This commit simply instantiates a new `RemoteInfo` with `BranchName` set to the provided value in case of a remote URI.
|
Second go at #1008 |
This was referenced Dec 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Feature. This PR ensures that specifying
--targetBranchoption works for repositories hosted in on-premise Azure Devops Server (or TFS), when providing a non-file URI.Currently specifying
--targetBranchfor Azure Devops Server (or TFS) has no effect if the URI is not for a local repository.🆕 What is the new behavior (if this is a feature change)?
Specifying
--targetBranchfor a remote repository will now correctly apply updates to the target branch.💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
?
📝 Links to relevant issues/docs
🤔 Checklist before submitting