Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Updater for packages.config files #31

Merged
merged 3 commits into from
Jul 9, 2017
Merged

Updater for packages.config files #31

merged 3 commits into from
Jul 9, 2017

Conversation

skolima
Copy link
Collaborator

@skolima skolima commented Jul 8, 2017

This follows on #30 change

Uses NuGet.exe installed as a package, however, there's a problem: behaviour of this tool is not the same as updating through Visual Studio UI. Main difference seems to be that install/uninstall PowerShell scripts aren't run.

Examples:
https://www.nuget.org/packages/System.IO.Abstractions/ would add app.config assembly mappings, but command line doesn't do this for some reason this doesn't happen any more from UI either
https://www.nuget.org/packages/StyleCop.Analyzers/ would update analyzers in .csproj, but command line doesn't do this


private async Task RunExternalCommand(string command)
{
var result = await _externalProcess.Run($"{command}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$"{command}" is exactly equivalent to command.

@AnthonySteele
Copy link
Member

Very good, but we should also merge #28 first

@cohen990
Copy link
Collaborator

cohen990 commented Jul 9, 2017

Needs re-doing following merge of #28

So that we can choose between 'dotnet add package' and 'nuget update' for updating the package
Even managed to sucessfully update some packages.
@skolima
Copy link
Collaborator Author

skolima commented Jul 9, 2017

Re-done on current master

@AnthonySteele AnthonySteele merged commit 1e63b65 into NuKeeperDotNet:master Jul 9, 2017
@skolima skolima deleted the old-style-updater branch July 10, 2017 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants