Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Fixes local source path escaping #404

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Fixes local source path escaping #404

merged 1 commit into from
Aug 21, 2018

Conversation

skolima
Copy link
Collaborator

@skolima skolima commented Aug 21, 2018

No description provided.

@skolima
Copy link
Collaborator Author

skolima commented Aug 21, 2018

Related to #386

@AnthonySteele
Copy link
Member

AnthonySteele commented Aug 21, 2018

ArgumentEscaper.EscapeAndConcatenate looks useful, but what is actually going wrong with adding " quotes? Are some of the args already IsSurroundedWithQuotes ?

Or is it bad to add quotes when they aren't needed (i.e. no actual spaces in the path)?

@skolima
Copy link
Collaborator Author

skolima commented Aug 21, 2018

I was adding a) quotes where they weren't required (see the updated test - there's no need to quote the first source) and b) not escaping the \ where it was required (thus the source C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\ was failing. CMD.exe is odd in that \ only needs to be escaped sometimes. Fun!

@skolima skolima merged commit 809cdcb into NuKeeperDotNet:master Aug 21, 2018
@skolima skolima deleted the fix-local-source-escaping branch August 21, 2018 12:11
@AnthonySteele
Copy link
Member

Ah, so a was not fatal but b was. Well spotted! and good that someone already has code to do the right thing with it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants