This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Improver Exception handling Octokit (GitHub). Exceptions will show more info than the current "Validation Error" #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTuinder
changed the title
shep1987
reviewed
Jun 28, 2019
|
I know it leads to duplication, but I don't see how I could create a global exeption handler for this class alone. I will do some research. |
|
Added global exception handler for class |
shep1987
approved these changes
Jul 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
feature (kid of)
When Octokit throws an error, the only thing logged is "Validation Error" which is not much help.
🆕 What is the new behavior (if this is a feature change)?
The Body of the http response (if there) is parsed to see if the real error can be determined.
If errors can be found in the body, the first will be in the message of the Exception thrown.
The original Exception is passed to the thrown Exception als innerException.
The thrown exception will be a NuKeeper exception.
💥 Does this PR introduce a breaking change?
no
🐛 Recommendations for testing
As an example you could try to run nukeeper on a repository that you only have read access to.
📝 Links to relevant issues/docs
🤔 Checklist before submitting