This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Added checkout directory parameter to repo command #922
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
A feature for setting the directory to check out to via a command line parameter in the
repo
command.Currently, the
repo
command creates a temporary folder below %APPDATA% to check out the repository to.🆕 What is the new behavior (if this is a feature change)?
The default is still the same. However, via the optional command line parameter
--checkoutdirectory
(or-cdir
) a custom directory can be provided, e.g.nukeeper repo <url> <token> -cdir "C:\Git"
.💥 Does this PR introduce a breaking change?
I don't think so, since the default behaviour is not changed and the command line switch is optional.
🐛 Recommendations for testing
📝 Links to relevant issues/docs
This solves the original request from #683 (though not the updated intention).
Although I tried setting the TMP-Variable as mentioned in the issue, the path with auto-generated temp folder names is still too long for óur project (I know, that is a discussion for itself), which is why I implemented this.
🤔 Checklist before submitting
-> Please point me to the right documentation, I will be glad to update it 😃
This is my first PR here, so feel free to highlight any changes I should make (e.g. code style) and I will try to adjust them shortly...