This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
Update Microsoft.CodeAnalysis.FxCopAnalyzers to 3.0 #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Directory.Build.props and make minimum changes to get it building without warning again Warning disabled: Null checks ( https://docs.microsoft.com/en-gb/visualstudio/code-quality/ca1062 ) - we need more null checks and/or more internal methods before turning that rule on Disposing (CA2000) looks like we can't, for reasons given here https://jmarcher.io/ca2000-welcome-to-hell/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Update
Microsoft.CodeAnalysis.FxCopAnalyzersto 3.0 inDirectory.Build.propsand make minimum changes to get it building without warning again
Warnings disabled:
Null checks ( https://docs.microsoft.com/en-gb/visualstudio/code-quality/ca1062 ) - we need more null checks and/or more internal methods before turning that rule on
Disposing (CA2000) looks like we can't, for reasons given here https://jmarcher.io/ca2000-welcome-to-hell/
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting