Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fx3] Investigate/fix field checksums #344

Open
jynik opened this issue Nov 6, 2014 · 2 comments
Open

[fx3] Investigate/fix field checksums #344

jynik opened this issue Nov 6, 2014 · 2 comments
Labels
Component: FX3 Firmware FX3 component Issue: Bug It's a bug and it oughta be fixed

Comments

@jynik
Copy link
Contributor

jynik commented Nov 6, 2014

While investigating a different issue, I found that the checksum test has been "turned off" in flash.c's NuandExtractField(). It smells like someone disabled it while debugging and never got back to it.

I'm registering this issue to follow up on this, and fix any checksum issues, if present.

@jynik jynik added the Issue: Task Something that should be done, but isn't a bug or an enhancement label Nov 13, 2014
@jynik jynik added the Issue: Enhancement Missing functionality, or a new feature request label Dec 23, 2014
@rtucker rtucker added Issue: Bug It's a bug and it oughta be fixed Component: Host General host software issues labels Aug 2, 2017
@bglod
Copy link
Contributor

bglod commented Sep 12, 2018

Appears to still be the case:

a1 = *(unsigned short *)(&ub[c+1]); // read checksum
a2 = crc16mp(0, ub, c+1); // calculated checksum
if (a1 == a2 || 1) {

@rtucker rtucker self-assigned this Sep 12, 2018
@rtucker
Copy link
Contributor

rtucker commented Sep 12, 2018

Removing the || 1 caused a flashed FPGA to not load on my A4. This will take some additional thought. (Are we even writing the checksum?)

@rtucker rtucker added Component: FX3 Firmware FX3 component and removed Component: Host General host software issues Issue: Enhancement Missing functionality, or a new feature request Issue: Task Something that should be done, but isn't a bug or an enhancement labels Sep 12, 2018
@rtucker rtucker removed their assignment Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: FX3 Firmware FX3 component Issue: Bug It's a bug and it oughta be fixed
Projects
None yet
Development

No branches or pull requests

3 participants