[libbladeRF] LMS DC calibration settings stored in calibration tables only gets loaded once #370
Labels
Issue: Bug
It's a bug and it oughta be fixed
Comments
jynik
added a commit
that referenced
this issue
Jan 29, 2015
Addresses issue #370. The LMS calibration registers must be loaded each time init_device() is called, as opposed to only during the post-FPGA load init, because the the user may have updated his or her calibration table since then.
|
Good catch, thank you! Added 4cbd29e to address this. |
jenselofsson
pushed a commit
to jenselofsson/bladeRF
that referenced
this issue
Feb 2, 2015
Addresses issue Nuand#370. The LMS calibration registers must be loaded each time init_device() is called, as opposed to only during the post-FPGA load init, because the the user may have updated his or her calibration table since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a device is first opened and initialized, LMS DC calibration data is read from the current calibration table and loaded into the LMS registers. All future device opens will not attempt to set these values again, until it has been power cycled.
If a device is first opened with one calibration table present, and then replaced with another table, the LMS settings from the new table will never get used. The frequency based DC offsets from the new table will still be used as expected, which may cause DC spikes/aliasing due to the possible discrepancies between the LMS calibration settings used in each table.
LMS calibration data can be loaded every time a device is opened by editing the
bladerf_priv.c: init_device()function and moving the call toapply_lms_dc_cals()out of the statementif ((val & 0x7f) == 0) { ... }The text was updated successfully, but these errors were encountered: