Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbladeRF: Format macro constants for new typedefs #577

Closed
rtucker opened this issue Aug 20, 2018 · 0 comments · Fixed by #623
Closed

libbladeRF: Format macro constants for new typedefs #577

rtucker opened this issue Aug 20, 2018 · 0 comments · Fixed by #623
Assignees
@rtucker
Labels
Component: Host General host software issues Issue: Enhancement Missing functionality, or a new feature request Resolve: PR will close Will be closed by an upcoming PR

Comments

@rtucker
Copy link
Contributor

rtucker commented Aug 20, 2018

The new typedefs should have corresponding #define'd aliases for the appropriate format macro constants (see https://en.cppreference.com/w/c/types/integer for ref).

Suggestion:

#define BLADERF_PRIuFREQ PRIu64
#define BLADERF_PRIxFREQ PRIx64
etc...
@rtucker rtucker added Issue: Enhancement Missing functionality, or a new feature request Component: Host General host software issues labels Aug 28, 2018
@rtucker rtucker self-assigned this Sep 5, 2018
@rtucker rtucker mentioned this issue Sep 5, 2018
Merged
@rtucker rtucker reopened this Sep 12, 2018
rtucker added a commit to rtucker/bladeRF that referenced this issue Sep 12, 2018
@rtucker
libbladeRF: add format macros for frequency, timestamp
fa40eed 
Adds new format macros for displaying bladerf_frequency and
bladerf_timestamp values to libbladeRF.h.

Transitions bladerf1.c and bladerf2.c to use these new macros,
and also cleans up a few more places where the typedefs aren't
currently used.

Also fixes a doxygen warning for undocumented #defines in
bladeRF2.h.

Fixes Nuand#577
Fixes Nuand#618
Fixes Nuand#620
@rtucker rtucker mentioned this issue Sep 12, 2018
Merged
@rtucker rtucker added the Resolve: PR will close Will be closed by an upcoming PR label Sep 12, 2018
rtucker added a commit that referenced this issue Sep 12, 2018
@rtucker
libbladeRF: add format macros for frequency, timestamp
045708a 
Adds new format macros for displaying bladerf_frequency and
bladerf_timestamp values to libbladeRF.h.

Transitions bladerf1.c and bladerf2.c to use these new macros,
and also cleans up a few more places where the typedefs aren't
currently used.

Also fixes a doxygen warning for undocumented #defines in
bladeRF2.h.

Fixes #577
Fixes #618
Fixes #620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtucker rtucker

Labels
Component: Host General host software issues Issue: Enhancement Missing functionality, or a new feature request Resolve: PR will close Will be closed by an upcoming PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libbladeRF: add format macros for frequency, timestamp rtucker/bladeRF
1 participant
@rtucker