Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible future features #4

Open
4 of 6 tasks
maxschalz opened this issue Apr 22, 2022 · 0 comments
Open
4 of 6 tasks

Possible future features #4

maxschalz opened this issue Apr 22, 2022 · 0 comments
Labels
discussion Open for discussion and input from others enhancement New feature or request

Comments

@maxschalz
Copy link
Member

maxschalz commented Apr 22, 2022

  • Add maximum number of iterations to Slice sampler.
    I think this is a good idea, however what should happen if that limit gets exceeded?
    Simply raise an error and kill the process or restart with another initial value?

    This question is irrelevant inasmuch as the maximum number of iterations of Slice is not part of Bicyclus.
    This must be implemented in the user's driver script.
  • Improve class structure somehow?
  • Copy useful functions from Pakistan/Elbonia case study into bicyclus?
  • Add examples and minimum working example. Remember to take into account Use updated likelihood calcuations, e.g., in examples #3
  • Should we redesign the logging function? AFAIK, it currently opens a file stream but does not close it properly. See write_to_log_file(...) in log.py. One simple way to do this could be to use a with open() context manager in log_print?
  • Allow to use either PyMC4 or PyMC5? Related to Upgrade to PyMC5 #27
@maxschalz maxschalz added enhancement New feature or request discussion Open for discussion and input from others labels Apr 22, 2022
@maxschalz maxschalz mentioned this issue May 20, 2022
maxschalz added a commit that referenced this issue May 20, 2022
Add example. Closes #3 and solves one open task in #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open for discussion and input from others enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant