Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better follow #443

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Better follow #443

merged 4 commits into from
Jun 12, 2023

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Jun 6, 2023

Fixes #436

@Nukesor Nukesor changed the base branch from main to development June 6, 2023 10:37
@codecov-commenter
Copy link

Codecov Report

Merging #443 (cc9c2af) into development (cc9c2af) will not change coverage.
The diff coverage is n/a.

❗ Current head cc9c2af differs from pull request most recent head 2d62b5b. Consider uploading reports for the commit 2d62b5b to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           development     #443   +/-   ##
============================================
  Coverage        78.08%   78.08%           
============================================
  Files               79       79           
  Lines             5454     5454           
============================================
  Hits              4259     4259           
  Misses            1195     1195           

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test Results

    3 files  ±  0    22 suites  ±0   2m 50s ⏱️ +39s
140 tests +  9  140 ✔️ +  9  0 💤 ±0  0 ±0 
300 runs  +18  300 ✔️ +18  0 💤 ±0  0 ±0 

Results for commit d554dd8. ± Comparison against base commit cc9c2af.

This pull request removes 3 and adds 12 tests. Note that renamed tests count towards both.
pueue::tests ‑ client::integration::follow::default
pueue::tests ‑ client::integration::follow::remote
pueue::tests ‑ client::integration::follow::remote_with_last_lines
pueue::tests ‑ client::integration::follow::default::case_1
pueue::tests ‑ client::integration::follow::default::case_2
pueue::tests ‑ client::integration::follow::fail_on_disappearing::case_1
pueue::tests ‑ client::integration::follow::fail_on_disappearing::case_2
pueue::tests ‑ client::integration::follow::fail_on_non_existing::case_1
pueue::tests ‑ client::integration::follow::fail_on_non_existing::case_2
pueue::tests ‑ client::integration::follow::last_lines::case_1
pueue::tests ‑ client::integration::follow::last_lines::case_2
pueue::tests ‑ client::integration::follow::wait_for_task::case_1
pueue::tests ‑ client::integration::follow::wait_for_task::case_2
…

♻️ This comment has been updated with latest results.

@Nukesor Nukesor changed the base branch from development to wait-success June 6, 2023 19:12
Base automatically changed from wait-success to development June 12, 2023 16:16
@Nukesor Nukesor merged commit 31a774a into development Jun 12, 2023
@Nukesor Nukesor deleted the better-follow branch June 12, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve pueue follow behaviour with a task that does not yet have logs
2 participants