Exitmap only scans relays that allow exiting AND thus have an exitflag, but

[thejustaguy]

If a relay only allows exiting to port 80, and thus doesn't get an exit flag, exitmap won't scan it, and it won't get checked for .exe patching when i'm scanning with https://github.com/leviathansecurity/exitmap/blob/master/src/modules/patchingCheck.py

[secretsquirrel]

Are you getting a particular error message? If so, paste it in.

[arlolra]

They're pointing out this:
https://github.com/NullHypothesis/exitmap/blob/master/src/relayselector.py#L88-L89

Exitmap should check if a relay allows any exiting, not just that it has the exit flag. I think the tor client will use any relay that satisfies its exiting requirements under certain conditions.

[NullHypothesis]

Exitmap should check if a relay allows any exiting, not just that it has the exit flag. I think the tor client will use any relay that satisfies its exiting requirements under certain conditions.

That sounds like a good solution to me.

In addition, we should log a warning if a relay allows exiting but does not have the "Exit" flag.

If anyone wants to write a patch, please do so. I might be able to fix that in a week or so.

[NullHypothesis]

This is now fixed in commit 1dd2eab.

Interestingly, right now there are 251 relays with some sort of exit policy which don't have the exit flag.

Thanks for reporting this, justaguyprojects!

[arlolra]

@NullHypothesis I'd be careful here. This (stem's is_exiting_allowed()) seems susceptible to the same problem as in #4 (complex exit policies are summarized as reject *).

[NullHypothesis]

@arlolra, you are right, it's affected by the same issue, thanks for pointing this out. What do you think about patch ed94d16?

[arlolra]

@NullHypothesis looks good. one comment inline

[NullHypothesis]

I merged the last changes in ff5696a. Thanks, everyone!