Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable faltest #728

Merged
merged 1 commit into from
Apr 28, 2020
Merged

re-enable faltest #728

merged 1 commit into from
Apr 28, 2020

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Apr 12, 2020 •
edited
Loading

@github-actions
Copy link

🚀 Deployed on https://5e928b8629b6af57d9304a77--emberclear.netlify.com

@github-actions
Copy link

Pull Request Test Coverage Report for Build fadac82f709c314493c6eeb9ee057c07b8d274e3-PR-728

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.314%
Totals Coverage Status
Change from base Build 8de538999d8c22d3a2972d183a62c475599cde46: 0.0%
Covered Lines: 1405
Relevant Lines: 2027
💛 - Coveralls

@NullVoxPopuli
Copy link
Owner Author

This needs to be changed to get the deploy comment URL: https://github.com/NullVoxPopuli/emberclear/blob/master/packages/smoke-tests/tests/smoke-test.js#L21

Or maybe the URL can be uploaded as an artifact?

@NullVoxPopuli
Copy link
Owner Author

What are 'outputs' https://github.com/nwtgck/actions-netlify/blob/develop/README.md#outputs

@NullVoxPopuli
Copy link
Owner Author

https://github.com/nwtgck/actions-netlify/blob/develop/.github/workflows/test.yml#L30

@NullVoxPopuli
Copy link
Owner Author

Looks like I have to dump the output to an artifact

https://stackoverflow.com/questions/59175332/using-output-from-a-previous-job-in-a-new-one-in-a-github-action

@github-actions
Copy link

🚀 Deployed on https://5e931acf396d24eb08f685ff--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e931ddf802ada500b8bc7e9--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e932072396d246403f68219--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e9323f9e757e42979262593--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e93274efdd5cff36f2193cd--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e93337a396d246d1bf68117--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e93392fabd8ccc3be284f38--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e93c0b1577652383d818ab9--emberclear.netlify.com

@github-actions
Copy link

🚀 Deployed on https://5e950f9087d3fe618e5f5e99--emberclear.netlify.com

@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
@github-actions
Copy link

🚀 Deployed on https://5ea72c5fa54a8f733a5a7245--emberclear.netlify.app

@github-actions
Copy link

🚀 Deployed on https://5ea7977fd3d2f5c405494468--emberclear.netlify.app

@github-actions
Copy link

🚀 Deployed on https://5ea798dcbe844eb140507923--emberclear.netlify.app

@github-actions
Copy link

🚀 Deployed on https://5ea79993a438a7ea2227a641--emberclear.netlify.app

@NullVoxPopuli NullVoxPopuli merged commit 6de472a into master Apr 28, 2020
@NullVoxPopuli NullVoxPopuli deleted the re-enable-e2e-tests branch April 28, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@NullVoxPopuli