Try fully linting gjs and gts (eslint + template-lint + prettier) #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://636ac93115cfa41c02aaaf4f--limber.netlify.app |
NullVoxPopuli
commented
Nov 7, 2022
| const configBuilder = { | ||
| modules: { | ||
| browser: { | ||
| get js() { |
There was a problem hiding this comment.
every "leaf object" in this structure defines an ESLint "overrides" entry.
Merged
NullVoxPopuli
force-pushed
the
try-quote-one-lint-quote
branch
from
710352e
to
7ccdccd
Compare
Try eslint --fix Try using the prettier integration Support conditional TypeScript optionally disable prettier in eslint via flag
NullVoxPopuli
force-pushed
the
try-quote-one-lint-quote
branch
from
7ccdccd
to
73028f2
Compare
|
this is stale, linting works on gjs/gts now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using:
Issues encountered:
--fixis broken with.gtsfiles ember-template-lint/ember-template-lint#2681