-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC Decode/Encode with multiple bytes per chunk #84
Open
lwus
wants to merge
11
commits into
Nullus157:main
Choose a base branch
from
lwus:prīmum
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "pr\u012Bmum"
Commits on May 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6a32d57 - Browse repository at this point
Copy the full SHA 6a32d57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b79c0 - Browse repository at this point
Copy the full SHA 90b79c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8b5a90 - Browse repository at this point
Copy the full SHA c8b5a90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19d7487 - Browse repository at this point
Copy the full SHA 19d7487View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58e8a6c - Browse repository at this point
Copy the full SHA 58e8a6cView commit details -
Handle unaligned output instead of using UB unsafe allocs
- Vec::from_raw_parts is much stricter than anticipated and requires deallocation to happen with the same alignment
Configuration menu - View commit details
-
Copy full SHA for 1382308 - Browse repository at this point
Copy the full SHA 1382308View commit details -
Encode with 5 base58 bytes per limb
- slightly more complex expansion from limb to output bytes but pretty solid perf gains
Configuration menu - View commit details
-
Copy full SHA for 6ae3c07 - Browse repository at this point
Copy the full SHA 6ae3c07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38468ad - Browse repository at this point
Copy the full SHA 38468adView commit details
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f6e175c - Browse repository at this point
Copy the full SHA f6e175cView commit details -
Configuration menu - View commit details
-
Copy full SHA for faaa09c - Browse repository at this point
Copy the full SHA faaa09cView commit details -
Simplify en/decoding chunks loops
- unrolling apparently does not help with performance. this simplifies a lot of the indexing and is also seemingly faster
Configuration menu - View commit details
-
Copy full SHA for 5926ef2 - Browse repository at this point
Copy the full SHA 5926ef2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.