Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC Decode/Encode with multiple bytes per chunk #84

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

RFC Decode/Encode with multiple bytes per chunk #84

wants to merge 11 commits into from

Commits on May 11, 2022

  1. Decode with multiple bytes per chunk

    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6a32d57 View commit details
    Browse the repository at this point in the history

  2. Fix main loop ending condition

    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    90b79c0 View commit details
    Browse the repository at this point in the history

  3. Do remaining bytes in 1 multiply loop

    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    c8b5a90 View commit details
    Browse the repository at this point in the history

  4. Add benchmarks for decode::into_vec_unsafe

    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    19d7487 View commit details
    Browse the repository at this point in the history

  5. Implement batched encode

    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    58e8a6c View commit details
    Browse the repository at this point in the history

  6. Handle unaligned output instead of using UB unsafe allocs 

    - Vec::from_raw_parts is much stricter than anticipated and requires
  deallocation to happen with the same alignment
    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1382308 View commit details
    Browse the repository at this point in the history

  7. Encode with 5 base58 bytes per limb 

    - slightly more complex expansion from limb to output bytes but pretty
  solid perf gains
    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    6ae3c07 View commit details
    Browse the repository at this point in the history

  8. Use bytemuck instead of raw unsafe align

    @lwus
    lwus committed May 11, 2022
    Configuration menu
    Copy the full SHA
    38468ad View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Small slice indexing optimization

    @lwus
    lwus committed May 17, 2022
    Configuration menu
    Copy the full SHA
    f6e175c View commit details
    Browse the repository at this point in the history

  2. Add sanity check for encoded output buffer length

    @lwus
    lwus committed May 17, 2022
    Configuration menu
    Copy the full SHA
    faaa09c View commit details
    Browse the repository at this point in the history

  3. Simplify en/decoding chunks loops 

    - unrolling apparently does not help with performance. this simplifies a
  lot of the indexing and is also seemingly faster
    @lwus
    lwus committed May 17, 2022
    Configuration menu
    Copy the full SHA
    5926ef2 View commit details
    Browse the repository at this point in the history