feat: use new gpt-3.5-turbo model #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ChatCompletionResponse instead of CreateCompletionRequest and CreateCompletionResponse
Helpmylyfe82
approved these changes
Mar 2, 2023
|
This works well for me and seems to write better commit messages :-) |
|
Working pretty well for me! I also made a slight change to the prompt: |
src/utils/openai.ts
Outdated
| @@ -94,7 +98,7 @@ export const generateCommitMessage = async ( | |||
|
|
|||
| return deduplicateMessages( | |||
| completion.choices | |||
| .map(choice => sanitizeMessage(choice.text!)), | |||
| .map(choice => sanitizeMessage(choice.message?.content ?? 'No Commit Message')), | |||
There was a problem hiding this comment.
We should throw an error instead of falling back to a made up commit message.
| const encoder = encodingForModel(model); | ||
| const model = 'gpt-3.5-turbo'; | ||
| // TODO: update for the new gpt-3.5 model | ||
| const encoder = encodingForModel('text-davinci-003'); |
There was a problem hiding this comment.
Was waiting for the new one to be released but I guess there's no point in blocking the feature.
|
Thanks! |
This was referenced Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the tokenizer that was just added doesnt have support for the new model yet, so still using the told model and 🤞 they are very similar.
I used it to generate its own commit message.