Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version of caniuse break current test #19

Closed
MoOx opened this issue Feb 3, 2015 · 4 comments
Closed

latest version of caniuse break current test #19

MoOx opened this issue Feb 3, 2015 · 4 comments

Comments

@MoOx
Copy link
Collaborator

MoOx commented Feb 3, 2015

The diff for border-radius get support test now have a difference for safari: { '#1': 6.1, x: 4, y: 3.1 }.
Note the #1 added. I take a quick look into recent caniuse db update and saw this diff Fyrd/caniuse@44dc9c2

Do you just want me to add this for the test ?
Maybe we should make test simpler (no deep equal) and just test keys to avoid testing data (we don't need to test data right?)

@Nyalab
Copy link
Owner

Nyalab commented Feb 4, 2015

I will change the way i test compat. For now it depends too much on fixed data. What i really need to test, is that i have to take data from raw files, transform it, and test if the output is correct. I will automatize that soon. But for now, yes, just look at real data, it will be enough. Thanks ✨

MoOx added a commit that referenced this issue Mar 30, 2015
@MoOx
Copy link
Collaborator Author

MoOx commented Mar 30, 2015

I've added a workaround in 5e117df to prevent issue for now :).
Not sure why caniuse keeps only one entry for and_chr & and_ff...

@Nyalab
Copy link
Owner

Nyalab commented Mar 30, 2015

Ok, i see, well, it works for now. Both of the browsers do not have the same rendering engine, so the both of them have to be tested.

@MoOx
Copy link
Collaborator Author

MoOx commented Mar 30, 2015

My point is that caniuse-db is just keeping one entry for those browsers. That's the weird part. Eg: Fyrd/caniuse@41bd4f0

@MoOx MoOx closed this as completed in 9b61c83 Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants