New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.3.0 to enable in browser usage. #26
Conversation
Note that babel-node behave now as node (just execute one file), that’s why we need to use babel-tape-runner.
feature.json is now a js
This commit is an optimisation for node of the previous browserify enhancement and keep the browserify compatibility.
Build now pass. See #19 workaround |
Can you move |
) | ||
) | ||
.map(file => file.replace(".json", "")) | ||
.map(feature => `"${feature}": function() { return require("${path.join("caniuse-db", "features-json", feature)}")}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring every features will add a lot of bytes to the browser build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know. But it's "lot's of bytes" vs "not working at all".
caniuse-db is a requirement as well as shelljs since it's used in postinstall hook. |
|
caniuse-api needs those 2 packages. For real. You already try to make some changes for this package but they got reverted because they were breaking everything. Are you just using caniuse-api somewhere? |
Also, that totally not the point of the PR so please use another issue for asking those weird changes that don't solve anything :p |
looks good to me, you can merge when you want |
1.3.0 to enable in browser usage.
@Nyalab here is a proposal for 1.3.0
import * as
changes)If you are ok with that, just tell me so I can merge and release.