Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from caniuse-db to caniuse-lite. Closes #57. #59

Merged
merged 2 commits into from May 3, 2017
Merged

Migrate from caniuse-db to caniuse-lite. Closes #57. #59

merged 2 commits into from May 3, 2017

Conversation

ben-eb
Copy link
Contributor

@ben-eb ben-eb commented Apr 20, 2017

I recommend a major version bump for this patch. Let me know if you have any queries or suggestions! 馃槂

Edit: It might be worth waiting for Browserslist 2 before releasing. poke @ai

Copy link
Collaborator

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for major release.

@ben-eb
Copy link
Contributor Author

ben-eb commented Apr 21, 2017

With Browserslist 2, we only have one test failure:

https://github.com/Nyalab/caniuse-api/blob/master/test/index.js#L32

The function receives this list of browsers.
    ie 5.5
    ie 6
    ie 7
    ie 8
    ie 9
    ie 10
    ie 11
    edge 12
    edge 13
    edge 14
    edge 15
    firefox 2
    firefox 3
    firefox 3.5
    firefox 3.6
    firefox 4
    firefox 5
    firefox 6
    firefox 7
    firefox 8
    firefox 9
    firefox 10
    firefox 11
    firefox 12
    firefox 13
    firefox 14
    firefox 15
    firefox 16
    firefox 17
    firefox 18
    firefox 19
    firefox 20
    firefox 21
    firefox 22
    firefox 23
    firefox 24
    firefox 25
    firefox 26
    firefox 27
    firefox 28
    firefox 29
    firefox 30
    firefox 31
    firefox 32
    firefox 33
    firefox 34
    firefox 35
    firefox 36
    firefox 37
    firefox 38
    firefox 39
    firefox 40
    firefox 41
    firefox 42
    firefox 43
    firefox 44
    firefox 45
    firefox 46
    firefox 47
    firefox 48
    firefox 49
    firefox 50
    firefox 51
    firefox 52
    firefox 53
    chrome 4
    chrome 5
    chrome 6
    chrome 7
    chrome 8
    chrome 9
    chrome 10
    chrome 11
    chrome 12
    chrome 13
    chrome 14
    chrome 15
    chrome 16
    chrome 17
    chrome 18
    chrome 19
    chrome 20
    chrome 21
    chrome 22
    chrome 23
    chrome 24
    chrome 25
    chrome 26
    chrome 27
    chrome 28
    chrome 29
    chrome 30
    chrome 31
    chrome 32
    chrome 33
    chrome 34
    chrome 35
    chrome 36
    chrome 37
    chrome 38
    chrome 39
    chrome 40
    chrome 41
    chrome 42
    chrome 43
    chrome 44
    chrome 45
    chrome 46
    chrome 47
    chrome 48
    chrome 49
    chrome 50
    chrome 51
    chrome 52
    chrome 53
    chrome 54
    chrome 55
    chrome 56
    chrome 57
    safari 3.1
    safari 3.2
    safari 4
    safari 5
    safari 5.1
    safari 6
    safari 6.1
    safari 7
    safari 7.1
    safari 8
    safari 9
    safari 9.1
    safari 10
    safari 10.1
    opera 9
    opera 9.5-9.6
    opera 10.0-10.1
    opera 10.5
    opera 10.6
    opera 11
    opera 11.1
    opera 11.5
    opera 11.6
    opera 12
    opera 12.1
    opera 15
    opera 16
    opera 17
    opera 18
    opera 19
    opera 20
    opera 21
    opera 22
    opera 23
    opera 24
    opera 25
    opera 26
    opera 27
    opera 28
    opera 29
    opera 30
    opera 31
    opera 32
    opera 33
    opera 34
    opera 35
    opera 36
    opera 37
    opera 38
    opera 39
    opera 40
    opera 41
    opera 42
    opera 43
    opera 44
    ios_saf 3.2
    ios_saf 4.0-4.1
    ios_saf 4.2-4.3
    ios_saf 5.0-5.1
    ios_saf 6.0-6.1
    ios_saf 7.0-7.1
    ios_saf 8
    ios_saf 8.1-8.4
    ios_saf 9.0-9.2
    ios_saf 9.3
    ios_saf 10.0-10.2
    ios_saf 10.3
    op_mini all

How would you like me to proceed?

@ben-eb
Copy link
Contributor Author

ben-eb commented May 1, 2017

Any updates, guys? Unfortunately this is currently a blocker for me; I'm happy to do the work but I need some direction on how I should update these tests to pass (or if it is still worth keeping this unit test).

Thanks!

@MoOx
Copy link
Collaborator

MoOx commented May 2, 2017

@ben-eb It seems you fixed the issue? I don't see any problem on this PR right now.

@ben-eb
Copy link
Contributor Author

ben-eb commented May 2, 2017

@MoOx When I wrote the PR, Browserslist 2 was not released, so when I tried adding it I got that test failure noted above. So I am wondering how this test should be updated; I didn't write it initially so I am not sure what it is there for. 馃槃

@Nyalab
Copy link
Owner

Nyalab commented May 2, 2017

Please just make the test pass by editing the regex. This is not used internally, this is for exporting the list of all supported browsers (a feature that was asked but not used internally yet).

Thanks for your time @ben-eb

@ben-eb
Copy link
Contributor Author

ben-eb commented May 2, 2017

@Nyalab Done! 馃憤

Copy link
Owner

@Nyalab Nyalab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@Nyalab Nyalab merged commit 9211b85 into Nyalab:master May 3, 2017
@ben-eb
Copy link
Contributor Author

ben-eb commented May 3, 2017

Thanks!

@ben-eb ben-eb deleted the caniuse-lite branch May 3, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants