Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0 #58

Closed
Nyholm opened this issue Jul 31, 2018 · 12 comments
Closed

Version 1.0 #58

Nyholm opened this issue Jul 31, 2018 · 12 comments

Comments

@Nyholm
Copy link
Owner

Nyholm commented Jul 31, 2018

I suggest version 0.4.0 should be the last release before 1.0.

Anything else we need to add or remove?

@Zegnat
Copy link
Collaborator

Zegnat commented Jul 31, 2018

We can take a final pass through all the public methods we expose. If all of them are described by external interfaces, I think we have now gotten to a fully stable public API.

Since we aren’t planning to add random methods of our own invention here, any bugs can still be fixed under version 1.0.0 but it does communicate that the API is done.

Should #49 set the upcoming “unreleased” to 1.0.0 to make this a promise?

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 1, 2018

That is my intention but I want to "play it safe" and do 0.4.0 first.

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 1, 2018

Hm.. With a second thought...
After we merge #60, could you do a check if all methods actually are described by an interface. If so, lets do 1.0.0 =)

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 2, 2018

Blocked by #65 and #66

@Zegnat
Copy link
Collaborator

Zegnat commented Aug 2, 2018

Hmm, I have no ideas what files I have and have not been involved with now. Should I try to find out to add @author markers? Do those markers add to the final line count?

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 2, 2018

I fixed that in #69

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 2, 2018

Are we ready for tagging 1.0?

@Zegnat
Copy link
Collaborator

Zegnat commented Aug 2, 2018

I opened #71 because I noticed that when reviewing a PR… but otherwise I think we are set!

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 2, 2018

Should I tag the release now?

@Zegnat
Copy link
Collaborator

Zegnat commented Aug 2, 2018

Do whatever you want with #72 and then go for it 👍 Anything else will simply be future work. I think these last 2 days have done enough streamlining!

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 2, 2018

#72 is just meta. That could be handled later.

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 2, 2018

Wohoo

@Nyholm Nyholm closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants