Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StreamFactory::copyToStream to (private) UploadedFile #60

Merged
merged 3 commits into from Aug 1, 2018
Merged

Move StreamFactory::copyToStream to (private) UploadedFile #60

merged 3 commits into from Aug 1, 2018

Conversation

Nyholm
Copy link
Owner

@Nyholm Nyholm commented Aug 1, 2018

No description provided.

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 1, 2018

This is the last public method Ive found that is not described in an interface.

@Nyholm Nyholm mentioned this pull request Aug 1, 2018
Closed
@Nyholm Nyholm requested a review from Zegnat August 1, 2018 09:17
@Zegnat Zegnat mentioned this pull request Aug 1, 2018
Merged
@Zegnat
Copy link
Collaborator

Zegnat commented Aug 1, 2018

This looks right. The only others I have found were Stream::__destruct, Stream::createFromResource, and Stream::create.

I don’t see how Stream::__destruct could ever be a problem. But the other two could theoretically get redefined by PSR in the future. (Though that sounds extremely unlikely.)

@Nyholm
Copy link
Owner Author

Nyholm commented Aug 1, 2018

Good. Excellent. Lets do this!

@Nyholm Nyholm merged commit f4a4ac3 into master Aug 1, 2018
@Nyholm Nyholm deleted the stream branch August 2, 2018 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zegnat Zegnat Awaiting requested review from Zegnat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nyholm @Zegnat