Added more tests and scrutnizer fixes #107
Conversation
| @@ -40,7 +40,7 @@ | |||
| /** @var bool */ | |||
| private $moved = false; | |||
|
|
|||
| /** @var int|null */ | |||
| /** @var int */ | |||
There was a problem hiding this comment.
It is actually impossible to create an UploadedFile with $size = null
src/UploadedFile.php
Outdated
| * | ||
| * @throws \RuntimeException on error | ||
| */ | ||
| private function copyToStream(StreamInterface $source, StreamInterface $dest, $maxLen = -1): void | ||
| private function copyToStream(StreamInterface $source, StreamInterface $dest): void |
There was a problem hiding this comment.
We are never using the third parameter, That is why I could remove the dead code
| @@ -19,7 +19,7 @@ public function testConstructorInitializesProperties() | |||
| $this->assertTrue($stream->isWritable()); | |||
| $this->assertTrue($stream->isSeekable()); | |||
| $this->assertEquals('php://temp', $stream->getMetadata('uri')); | |||
| $this->assertInternalType('array', $stream->getMetadata()); | |||
| $this->assertIsArray($stream->getMetadata()); | |||
There was a problem hiding this comment.
assertInternalType is deprecated
|
Im done with this PR now. |
|
I don’t understand the Travis error on this one… It seems to complain about I haven’t used PHPStan before so this will be interesting to check out. Overall all the code changes look good to me! |
|
PHPStan is pretty cool. We do get a few false negatives but that is fine. I added the docs on It is not an actual BC break for two reasons:
Thank you for the review |
No description provided.