Moved Inbox verify variable to be assigned before getMessages call #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narcolapser
pushed a commit
that referenced
this pull request
Nov 13, 2017
This problem would cause problems for a number of situations, so I feel it is important to get it out now. In the future I should probably be a little more through before I cut releases with new features like the ignore verify option, as that is what caused this. Really I just need to give this library more love in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on an Inbox instance initialization, if getNow is set to True, it leads to an attribute error on Line 53 since self.verify is defined after the call to getMessages().