-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry: Encapsulate page layout (#1823) #1824
Conversation
Added Gemfile, required to run a local test environment.
…, referring to a page template in the folder.
@MikeRalphson , please have a look when you get a moment. BTW, you'll notice some changes to the YAML front matter. I renamed If you think it's important to have the filename be the same as the schema type ID, we can add a YAML comment indicating that, and also include that requirement in the _contributing.md file. |
@MikeRalphson, if you want to allow more flexibility for the contributor to include an extended description of the registry entry, I can think of a couple of ways to do this:
The first option is more like OpenAPI's In either case, we can specify in our contributing guidelines that the description content should not use |
Generally 👍 to all of this, thanks!. The use of Jekyll That said, I am not in favour of replacing
I think splitting the description into a one-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per comments above.
Changes were requested some time ago, but the pull request hasn't been updated, so I'm closing. Feel free to open a new pull request, based off the current release, for us to review at any time. |
Partially addresses #1823. For now, focusing only on the Alternative Schema registry, but if we are OK with the approach, I can do the same for the other registries.
This extracts the boilerplate markdown to a new
_includes/alternative-schema-entry.md
file, referenced by an{% include %}
tag in each collection item.