Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the use of "binary" and "byte" formats #3187

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

handrews
Copy link
Member

@handrews handrews commented Mar 5, 2023

Fixes #1544 and #3175.

Add a brief explanation as a subsection of Data Types, and update the relevant examples. Specifically:

  • Don't use format: byte for a whole message body
  • Fix multipart/mixed example to be multipart/form-data (because multipart/mixed does not name its parts and therefore cannot be represented with an object schema)
  • Add an application/x-www-form-urlencoded example, which is where format: byte needs to be used

@handrews handrews added the 3.0.4 label Mar 5, 2023
Add a brief explanation as a subsection of Data Types, and
update the relevant examples.  Specifically:

* Don't use `format: byte` for a whole message body
* Fix `multipart/mixed` example to be `multipart/form-data`
  (because `multipart/mixed` does not name its parts and
  therefore cannot be represented with an object schema)
* Add an `application/x-www-form-urlencoded` example,
  which is where `format: byte` needs to be used
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants