Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2MetadataUrl #3625

Closed
wants to merge 198 commits into from
Closed

oauth2MetadataUrl #3625

wants to merge 198 commits into from

Conversation

AxelNennker
Copy link
Contributor

Add oauth2MetadataUrl to oauth2 allows the client to download the OAuth2 metadata to download the RFC8414 OAuth2 metadata.

Fixes #3595

alasdairhurst and others added 30 commits February 25, 2020 15:08
…branches (#2597)

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
* fix: v2.0 maintainers and version/date

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>

* Add some largely non-visible SEO improvements to the rendered spec

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
* nuke proposal prefixes

* Add YYYY-MM-DD prefixes to proposal documents

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
* fix: md2html/build.sh specify bash in shebang

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>

* fix: changes for abstract title in md2html.js

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
…mas) (#2614)

* Add test cases for valid and invalid top-level schemaObject types

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>

* Update workflow actions to node 14

Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
Makes the workflow trigger match the comment, thus giving people more time to add agenda items
#2157: Update schema to validate refs in headers of encoding objects
Add accessible meetings slide to agenda template
This makes metaschema consistent with the 3.0.x spec.

Refs #2666
* fix: typo spelling grammar

* Update proposals/2019-07-17-Webhooks.md

change ``request`` to ``requests``

Co-authored-by: Nate <37554478+servusdei2018@users.noreply.github.com>

Co-authored-by: Nate <37554478+servusdei2018@users.noreply.github.com>
generated via:
perl -MYAML::XS -MJSON::MaybeXS -we'$YAML::XS::Boolean="JSON::PP"; print Dump(JSON::MaybeXS->new->decode(do { local $/; <> }))' input.json > output.yaml
* minor simplification of v3.1 schema

"if the X property is present, then apply this constraint to property X" can
be simplified by simply stating the constraint for property X.

* add missing constraint to "header"

https://spec.openapis.org/oas/v3.1.0#headerObject

* allowEmptyValue and allowReserved don't make sense for headers

* collapse single-item "enum"s in "cookie" and "header" to "const"
If the wrong type is used for a particular piece of data, then a bare
"required" will validate as true, causing the "if" clause to be true, which
can lead to confusing errors when the "then" schema then fires, instead of the
error occurring at a higher position in the schema.
https://spec.openapis.org/oas/v3.1.0#pathTemplating
"The value for these path parameters MUST NOT contain any unescaped “generic syntax” characters described by [[!RFC3986]]: forward slashes (/), question marks (?), or hashes (#)."
* Update 3.1 schema id for patch release

* Generate JSON for new version of 3.1 schemas

* Catchup v3.0 schema with #2158

* Catchup v3.0 schemas with #2673

* Catchup v3.0 schemas with #2706

* Update schema id for 3.0 release
2nd attempt at this. Adding ".md" suffix. Intended to be a place for all our SIGs to better define who they are, how to join, expectations, etc.
- name is required (for parameter)
- the map under content must contain only one entry

as per https://spec.openapis.org/oas/v3.1.0#fixed-fields-9
Project's url https://github.com/OverSpeedIO/koa2-oas3 shows 404. Can't find the project through google either. Looks like the project closed.
Also normalize whitespace in table headers
Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
dependabot bot and others added 2 commits March 11, 2024 07:56
Bumps [@hyperjump/json-schema](https://github.com/hyperjump-io/json-schema) from 1.7.2 to 1.7.3.
- [Commits](https://github.com/hyperjump-io/json-schema/commits)

---
updated-dependencies:
- dependency-name: "@hyperjump/json-schema"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…son-schema-1.7.3

Bump @hyperjump/json-schema from 1.7.2 to 1.7.3
@handrews handrews added security security: auth Authentication including overlap with authorization labels Mar 11, 2024
dependabot bot and others added 7 commits March 18, 2024 07:55
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 1.3.1 to 1.4.0.
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v1.4.0/packages/vitest)

---
updated-dependencies:
- dependency-name: vitest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Proposing updates to the TSC processes around membership.
Bumps [markdown-it](https://github.com/markdown-it/markdown-it) from 14.0.0 to 14.1.0.
- [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md)
- [Commits](markdown-it/markdown-it@14.0.0...14.1.0)

---
updated-dependencies:
- dependency-name: markdown-it
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…-14.1.0

Bump markdown-it from 14.0.0 to 14.1.0
clarifying the provisional period
@LasneF
Copy link

LasneF commented Mar 21, 2024

Looks fair , we should update the meta schema soemthing around this line
https://github.com/OAI/OpenAPI-Specification/blob/main/schemas/v3.1/schema.yaml#L807

but question to @handrews should it goes to a dedicated schema 3.2 ...

@AxelNennker
Copy link
Contributor Author

Like this?

diff --git a/schemas/v3.1/schema.yaml b/schemas/v3.1/schema.yaml
index 68fcc0d..298ff51 100644
--- a/schemas/v3.1/schema.yaml
+++ b/schemas/v3.1/schema.yaml
@@ -799,6 +799,9 @@ $defs:
           properties:
             flows:
               $ref: '#/$defs/oauth-flows'
+            oauth2MetadataUrl:
+              type: string
+              format: uri
           required:
             - flows

earth2marsh and others added 2 commits March 21, 2024 09:16
ty @karenetheridge for spotting
Update actions used in respec workflow
@lornajane lornajane requested a review from a team March 21, 2024 16:33
@lornajane
Copy link
Contributor

The meta schema can be updated later on, it doesn't need to be part of this change.

versions/3.2.0.md Outdated Show resolved Hide resolved
earth2marsh and others added 5 commits March 25, 2024 08:32
Co-authored-by: Lorna Jane Mitchell <lorna@lornajane.net>
Replaced a longer draft features section with a proposed proposal process
@AxelNennker
Copy link
Contributor Author

Hi, the longer this mini PR stays unresolved the bigger the mess I create. Sorry.
It seems I did something that led to many more commits being in this.
Could somebody please help me getting this straight again, please?
Otherwise, I would go the radical way and close this PR, delete my fork, re-create it and create a new PR. But I guess there is a more elegant way to add this mini PR to OAI.

@lornajane
Copy link
Contributor

@AxelNennker I'l take a look and see if I can untangle it!

@lornajane
Copy link
Contributor

I can't guess what happened here, but I don't see your original commits anywhere so I can't recover them.

As you can tell from our pull request queue, it's not unusual for pull requests to be open for longer periods of time, so it would be good to understand what happened here so you can contribute this change (and hopefully many others) safely! The fastest route forward is to recreate the pull request (I'm sorry, I realise this wasn't the first time you proposed this change, but I'm in support of us accepting it so let's persevere). My tips for success:

  • branch from the 3.2.0 branch.
  • open the pull request from that branch.
  • don't click any "update" buttons presented to you by GitHub, it has a very limited view of how git should be used and it doesn't fit our workflow. If your PR gets so out of date that it needs to be rebased, we can help you to do that,

I'm closing this pull request because I feel like I have to - we can't merge it as it is - but I'm looking out for it's replacement!

@lornajane lornajane closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security: auth Authentication including overlap with authorization security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet