Improvements to requestWithAutomaticAccessTokenRenewal
#693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes error handling, and makes a couple of improvements to implementation of the
requestWithAutomaticAccessTokenRenewal
function:tokenExpired
;onTokenRenewal
parameter as truly optional - perform the token renewal even ifonTokenRenewal
isnil
;self
in the completion block forrenewAccessToken
call.The main issue I had was that
requestWithAutomaticAccessTokenRenewal
would swallow all errors and convert them to the emptytokenExpired
errors, preventing any possibility of implementing custom error handling logic on the client side: