Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does COB want to inherit "system" from RO? #206

Open
ddooley opened this issue Jun 28, 2022 · 5 comments
Open

Does COB want to inherit "system" from RO? #206

ddooley opened this issue Jun 28, 2022 · 5 comments

Comments

@ddooley
Copy link
Contributor

ddooley commented Jun 28, 2022

With reference to oborel/obo-relations#607 we need a decision from COB about taking on "system", which RO seeks to deprecate for lack of modelling support (if there is a group that wants to focus on systems modelling over and beyond process modelling we welcome that!).

Currently the RO definition of system is: A material entity consisting of multiple components that are causally integrated."

After RO obsoletes "system", then ENVO will need a new parent term for "environmental system".

@cmungall
Copy link
Contributor

cmungall commented Jun 30, 2022

I vote no on this.

The term "system" is too vague, many different entities have system-like aspects.

If you want to say your class has a system-like aspect then just go ahead and describe what that system-like aspect is, no need for a vague upper ontology term.

I am responsible for adding this to RO, I think this was a mistake. As far as I know the only place it is used is in ENVO, and I don't think it adds any value there:

image

image

Other ontologies that refer to systems (e.g anatomical system in uberon, system process in GO) don't actually use the RO class.

@bpeters42
Copy link
Contributor

bpeters42 commented Jul 1, 2022 via email

@pbuttigieg
Copy link

We'll create and maintain system in ENVO. I don't think it's vague at all.

'observatory system' seems to be better placed under 'processed
material' (or device) anyway.

This makes absolutely no sense to me.

@bpeters42
Copy link
Contributor

bpeters42 commented Aug 15, 2022 via email

@cmungall
Copy link
Contributor

cmungall commented Jul 17, 2023

Just picking up this conversation again.

@pbuttigieg

We'll create and maintain system in ENVO. I don't think it's vague at all.

This is not unreasonable as an incremental step - after 10 years no one else has used "system" other than ENVO. So if ENVO needs it to group "carbonate system of ocean water" with "ecosystem" and "processing line" that becomes an ENVO issue, and we can discuss the relative merits of that grouping on the ENVO tracker.

However, there is a possibility we are missing out on a potentially useful grouping that could be used for other ontologies here. @pbuttigieg maybe you can help us understand the use case for grouping this way and help us determine objective criteria for classification that is less vague?

I apologize for using the term "vague" in my original comment - it would be better to say that there needs to be more documentation on how to apply this class consistently.

Also, I will make an issue in the ENVO tracker to adopt "system"

'observatory system' seems to be better placed under 'processed
material' (or device) anyway.

This makes absolutely no sense to me.

I think you are right in that the label is confusing. I made an issue for this on the OBI tracker; obi-ontology/obi#1718

But note that "processed material entity" is now in COB. I still think there are some issues with scope of this class but I think this is a side issue here. We can make a new COB issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants