Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with OBI "processed material" #1718

Open
cmungall opened this issue Jul 17, 2023 · 1 comment
Open

Problems with OBI "processed material" #1718

cmungall opened this issue Jul 17, 2023 · 1 comment
Assignees

Comments

@cmungall
Copy link
Contributor

cmungall commented Jul 17, 2023

class: OBI:0000047
name: processed material
def: "Is a material entity that is created or changed during material processing." []
equivalent_to: BFO:0000040 ! material entity
  and
  OBI:0000312 ! is_specified_output_of
  some OBI:0000094 ! material processing

material processing is defined as A planned process which results in physical changes in a specified input material
= achieves_planned_objective some 'material transformation objective'

which is itself defined as an objective specifiction[sic] that creates an specific output object from input materials.

This doesn't specify what an input material is, neither does the def of objective specification.

  1. The label for OBI:0000047 is misleading. "material" sounds like a mass noun rather than an object. It is odd to think of the Empire State Building as "material", yet I think it is intended to classify here. If this the intent the label should be "processed material entity"?
  2. This is an injector class, it claims a broad variety of subclasses from multiple ontologies with different scopes, as such I think this is (inadvertently) violating https://obofoundry.org/principles/fp-005-delineated-content.html
  3. It is inconsistently applied (inevitable, for an injector class). For example, we would expect to see the following under it:
    • IAO: photographic print
    • random access memory
    • guar gum
    • manufactured

Or maybe I'm wrong and processed material should only be used for materials in the sense of substances, but there needs to be more guidance in what is included and what is excluded

UPDATE I did not need to write so much, COB already uses the label "processed material entity" signaling intent. I think for now if OBI updates the label to sync with COB that is sufficient to close this issue for now, and we can take everything else to the COB tracker

@bpeters42
Copy link
Contributor

Should partially be addressed when we do the COB merge in #1671

@bpeters42 bpeters42 self-assigned this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants